Changeset 6e4758

Timestamp:

06/19/12 16:51:35 (12 months ago)

Author:

Micke Prag <micke.prag@…>

Branches:

('master', '668dd99ac278cfd419d67879b141678facea630a')

Children:

ae7b9b8c1a6abbaacb0643cb53cd1e3435594849

Parents:

ffebd4ed4c7fbf3eef10fbdb86deb87b19db888f

git-author:

Micke Prag <micke.prag@telldus.se>2012-06-19 16:51:35+02:00

git-committer:

Micke Prag <micke.prag@telldus.se>2012-06-19 16:51:35+02:00

Message:

Add comment on why we disable some of the default tests

File:

• telldus-core/tests/CMakeLists.txt (modified) (1 diff)

telldus-core/tests/CMakeLists.txt

@@ -1 +1 @@
 SET(ENABLE_TESTING      FALSE   CACHE BOOL "Enable unit tests")
 
+#We have disabled some of the default tests in the google style guidelines
+# whitespace/tab
+#  We are using tabs for indentation, not spaces, in our code
+#
+# whitespace/parens
+#  We believe grouping of parameters with spaces in some functions could ease the readability
+#
+# whitespace/line_length
+#  Although you should try to keep the lines short it should not be a requirement (at least for now)
+#
+# whitespace/labels
+#  Since we use tabs instead of spaces for indentation, this test makes no sense
+#
+# runtime/rtti
+#  We are using dynamic_cast for the events. We use this to be able to send arbitrary data
+#  trought the events.
+#
 SET(cpplint_filters
         +whitespace/use_tab_for_indentation,-whitespace/tab,-whitespace/parens,-whitespace/line_length,-whitespace/labels,-runtime/rtti