Changeset 9352ae

Timestamp:

06/19/12 12:30:52 (11 months ago)

Author:

Micke Prag <micke.prag@…>

Branches:

('master', 'a231b56d57a69513303d0061f5fa3e3cd51c85c1')

Children:

a165e414fd50524c4aa985e47d6bdc086ae382b6

Parents:

5d2e3f33c87bff86f7fe5b287bf8e4bf9f153e90

git-author:

Micke Prag <micke.prag@telldus.se>2012-06-18 15:01:33+02:00

git-committer:

Micke Prag <micke.prag@telldus.se>2012-06-19 12:30:52+02:00

Message:

All parameters should be named in a function according to Google style guidelines "readability/function"

Location:

telldus-core/common

Files:

• Event.h (modified) (1 diff)
• Message.h (modified) (1 diff)
• Thread.h (modified) (1 diff)

telldus-core/common/Event.h

@@ -42 +42 @@
                 bool isSignaled();
                 void signal();
-                virtual void signal(EventData *);
+                virtual void signal(EventData *eventData);
                 EventDataRef takeSignal();
 

telldus-core/common/Message.h

@@ -14 +14 @@
         public:
                 Message();
-                explicit Message(const std::wstring &);
+                explicit Message(const std::wstring &functionName);
                 ~Message(void);
 
-                void addArgument(const std::wstring &);
+                void addArgument(const std::wstring &value);
                 // void addSpecialArgument(const std::wstring &);
                 // void addSpecialArgument(int);
                 // void addSpecialArgument(const char *);
-                void addArgument(int);
-                void addArgument(const char *);
+                void addArgument(int value);
+                void addArgument(const char *value);
 
-                static bool nextIsInt(const std::wstring &);
-                static bool nextIsString(const std::wstring &);
+                static bool nextIsInt(const std::wstring &message);
+                static bool nextIsString(const std::wstring &message);
 
-                static std::wstring takeString(std::wstring *);
-                static int takeInt(std::wstring *);
+                static std::wstring takeString(std::wstring *message);
+                static int takeInt(std::wstring *message);
 
         private:

telldus-core/common/Thread.h

@@ -23 +23 @@
                         virtual ~Thread();
                         void start();
-                        void startAndLock(Mutex *);
+                        void startAndLock(Mutex *lock);
                         bool wait();